Skip to content

enable static builds of openjpeg#6373

Merged
vicroms merged 3 commits intomicrosoft:masterfrom
Neumann-A:patch-7
May 9, 2019
Merged

enable static builds of openjpeg#6373
vicroms merged 3 commits intomicrosoft:masterfrom
Neumann-A:patch-7

Conversation

@Neumann-A
Copy link
Contributor

No description provided.

@cenit
Copy link
Contributor

cenit commented May 9, 2019

BUILD_SHARED_LIBS is already defined by vcpkg toolchain[1]. If you think that the static build is ok, it's enough to remove the initial check

[1]

if(VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic")
list(APPEND _csc_OPTIONS -DBUILD_SHARED_LIBS=ON)
elseif(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
list(APPEND _csc_OPTIONS -DBUILD_SHARED_LIBS=OFF)

@Neumann-A
Copy link
Contributor Author

@cenit good to know. Changed the code accordingly.

@vicroms: why did you add vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY) in #5937. https://github.com/uclouvain/openjpeg/blob/master/INSTALL.md reads like static libraries are ok (although not explicitly mentioned)

@cenit
Copy link
Contributor

cenit commented May 9, 2019

@Neumann-A my bad. I did the mistake here (or maybe there were some reasons for that... can't remember now), @vicroms is fine: 812cabf

@vicroms vicroms merged commit 2d11443 into microsoft:master May 9, 2019
@Neumann-A Neumann-A deleted the patch-7 branch May 10, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants